Re: ecpg tests broken by pgindent run

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Boszormenyi Zoltan <zb@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Meskes <meskes@postgresql.org>, pgsql-hackers@postgresql.org
Date: 2010-02-26T17:23:54Z
Lists: pgsql-hackers

Bruce Momjian wrote:
>>>>   
>>>>         
>>> Don't look further, interfaces/ecpg/include/sqlda.h has changed
>>> by the pgindent run.
>>>       
>> Yea, it is that, and sqltypes.h and one other file I am trying to find
>> now.
>>     
>
> I have reverted changes to three include files who's output appears in
> the regression tests.   I asssume this is new 9.0 behavior because I
> didn't have this issue before.   I also updated the pgindent script to
> prevent these from being changed in the future.
>
>   

Should not the instructions include doing a full set of regression tests 
to ensure that nothing breaks? The new installcheck-world target should 
help there.

cheers

andrew