Horton
Menu

Re: knngist patch support

Teodor Sigaev <teodor@sigaev.ru>

View thread
From: Teodor Sigaev <teodor@sigaev.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-02-13T20:59:27Z
Lists: pgsql-hackers 
> Reflecting on it, it seems to me that the separate SearchSysCacheN()
> macros are obviously cleaner and closer to preferred project style than
> the existing code with all those explicit zeroes.  So I think there's
> a case for migrating to that style even if we didn't have a concern
> about the max number of lookup keys.

http://www.sigaev.ru/misc/syscache-0.1.gz

Patch enlarges number of arguments of SearchSysCache and friends to 5 and 
introduces SearchSysCacheN (and friends) macroses. All 
SearchSysCache/SearchSysCacheCopy/SearchSysCacheExists/SearchSysCacheList/GetSysCacheOid 
calls are converted into calling macroses.

For compatibility, we could rename SearchSysCache into SearchSysCacheSomething 
and provide SearchSysCache function for old code.
-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/