Horton
Menu

Re: [PATCH] Provide rowcount for utility SELECTs

Boszormenyi Zoltan <zb@cybertec.at>

View thread
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@commandprompt.com>, Peter Eisentraut <peter_e@gmx.net>, Hans-Juergen Schoenig <hs@cybertec.at>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-02-12T18:29:08Z
Lists: pgsql-hackers

Attachments

Robert Haas írta:
> On Fri, Feb 12, 2010 at 10:48 AM, Boszormenyi Zoltan <zb@cybertec.at> wrote:
>   
>> I added a small change to protocol.sgml for the
>> "CommandComplete" message describing the change.
>> Is it enough?
>>     
>
> Ah, I didn't even see that that section needed to be updated.  Good
> catch.  I'd suggest the following wording:
>
> For a <command>SELECT</command> or <command>CREATE TABLE AS</command>
> command, the tag is SELECT rows... [and the rest as you have it]
>
> We should probably also retitle that section from "Retrieving Result
> Information for Other Commands" to "Retrieving Other Result
> Information" and adjust the text of the opening sentence similarly.
>
> Also I think you need to update the docs for PQcmdtuples to mention
> that it not works for SELECT and CTAS.
>   

I mentioned the "WITH" command, instead of CTEs.

Best regards,
Zoltán Böszörményi

-- 
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/