Re: [PATCH] Provide rowcount for utility SELECTs

Alvaro Herrera írta:
> Robert Haas escribió:
>   
>> On Thu, Feb 11, 2010 at 2:38 PM, Alvaro Herrera
>> <alvherre@commandprompt.com> wrote:
>>     
>>> Robert Haas escribió:
>>>
>>>       
>>>> I was all prepared to admit that I hadn't actually looked at the patch
>>>> carefully enough, but I just looked at (and CVS HEAD) again and what
>>>> you've written here doesn't appear to describe what I'm seeing in the
>>>> code:
>>>>
>>>>                               if ((portal->strategy != PORTAL_ONE_SELECT) && (!portal->holdStore))
>>>>                                       FillPortalStore(portal, isTopLevel);
>>>>
>>>> So one of us is confused... it may well be me.
>>>>         
>>> Ah, it seems I misread it ... but then I don't quite see the point in
>>> that change.
>>>       
>> Well the point is just that Zoltan is adding some more code that
>> applies to both branches of the switch, so merging them saves some
>> duplication.
>>     
>
> But then there's no other branches, so why not just put it below the
> switch?
>   

Well, for one because the PORTAL_MULTI_QUERY case doesn't
set the command tag even there was one from the last one and the
caller provided the non-NULL pointer. That would be behaviour change.

>>> Well, not doing a full review anyway, so never mind me.
>>>       
>> Actually I was sort of hoping you (or someone other than me) would
>> pick this up for commit...
>>     
>
> Hmm ...
>
>   


-- 
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/