Re: Review of Writeable CTE Patch

Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

From: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, Merlin Moncure <mmoncure@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2010-02-03T23:03:59Z

Lists: pgsql-hackers

Attachments

dmlwith8.patch (text/plain) patch

Hi,

Attached is an updated patch.  I'm now going to start working on the
documentation and I'll send it in a separate patch a bit later.

On 2010-02-03 16:53 UTC+2, Robert Haas wrote:
> Some thoughts:

> This patch
> removes a number of other assertions as well, but I don't know enough
> about those other spots to judge whether all of those cases are
> sensible.

I put back the Asserts in make_modifytable().  The one in
ExecInitModifyTable() is not true any more and neither is the Assert in
transformInsertStatement().

Regards,
Marko Tiikkaja