Re: Patch: libpq new connect function (PQconnectParams)
Joe Conway <mail@joeconway.com>
From: Joe Conway <mail@joeconway.com>
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: "Hackers (PostgreSQL)" <pgsql-hackers@postgresql.org>
Date: 2010-01-28T06:32:30Z
Lists: pgsql-hackers
Attachments
- PQconnectParams-final.patch (text/x-patch) patch
On 01/26/2010 02:55 PM, Guillaume Lelarge wrote: > Le 26/01/2010 19:43, Joe Conway a écrit : >> On 01/25/2010 03:21 PM, Guillaume Lelarge wrote: >>> I didn't put any documentation before knowing which one will be choosen. >>> So we still need to work on the manual. >> >> Please send the documentation as a separate patch. Once I have that I >> will commit the posted patch, barring any objections in the meantime. > > You'll find it attached with this mail. Please read it carefully, my > written english is not that good. Final committed patch attached. One last code correction -- in psql/startup.c the original patch defines the keywords array in the body of the code, rather than at the top of the block. Minor improvements ( hopefully ;-)) to the documentation as well. Joe