Horton
Menu

Re: testing cvs HEAD - HS/SR - missing file

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Erik Rijkers <er@xs4all.nl>, pgsql-hackers@postgresql.org
Date: 2010-01-27T10:05:53Z
Lists: pgsql-hackers 
Fujii Masao wrote:
> *** a/src/backend/replication/walsender.c
> --- b/src/backend/replication/walsender.c
> ***************
> *** 661,666 **** XLogSend(StringInfo outMsg)
> --- 661,673 ----
>   
>   		sentPtr = endptr;
>   
> + 		if (sentPtr.xrecoff >= XLogFileSize)
> + 		{
> + 			/* crossing a logid boundary */
> + 			sentPtr.xlogid += 1;
> + 			sentPtr.xrecoff = 0;
> + 		}
> + 
>   		/*
>   		 * Read the log directly into the output buffer to prevent
>   		 * extra memcpy calls.
> 

Before that, endptr is advanced using XLByteAdvance() macro, which does
handle xlogid boundaries. Is XLByteAdvance() broken?

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com