Re: Miscellaneous changes to plperl [PATCH]
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tim Bunce <Tim.Bunce@pobox.com>
Cc: Alex Hunsaker <badalex@gmail.com>, "David E. Wheeler" <david@kineticode.com>, pgsql-hackers@postgresql.org
Date: 2010-01-23T23:26:04Z
Lists: pgsql-hackers
Tim Bunce wrote:
>> - } keys %$imports;
>> + } sort keys %$imports;
>>
>
> Ok, good.
>
>
>> - my $funcsrc;
>> - $funcsrc .= qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src } ];
>> - #warn "plperl mkfuncsrc: $funcsrc\n";
>> - return $funcsrc;
>> + return qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src } ];
>>
>>
>
> Ok. (I don't think that'll clash with any later patches.)
>
>
> So, what now? Should I resend the patch with the two 'ok' changes above
> included, or can the committer make those very minor changes?
>
>
>
I'll pick these up, if Alex marks it ready for committer.
cheers
andrew