Re: Lock Wait Statistics (next commitfest)
Mark Kirkwood <markir@paradise.net.nz>
From: Mark Kirkwood <markir@paradise.net.nz>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2009-10-03T23:22:03Z
Lists: pgsql-hackers
Jeff Janes wrote: > > The total wait time is equal to the max wait time (which are both > equal to l_end)? > One or both of those has to end up being wrong. At this stage, is > l_end supposed to be the last wait time, or the cumulative wait time? > > > Hmm - I may well have fat fingered the arithmetic, thanks I'll take a look! > One of the things in the patch review checklist is about compiler > warnings, so I am reporting these: > > lock.c: In function `LockAcquire': > lock.c:797: warning: passing arg 1 of `pgstat_init_lock_wait' discards > qualifiers from pointer target type > lock.c:802: warning: passing arg 1 of `pgstat_end_lock_wait' discards > qualifiers from pointer target type > > > > Right, will look at too. Cheers Mark