Re: Re: csv format for psql
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Daniel Verite <daniel@manitou-mail.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, pgsql-hackers@postgresql.org
Date: 2018-03-21T17:27:33Z
Lists: pgsql-hackers
Hi Daniel, On 3/10/18 1:49 AM, Fabien COELHO wrote: > >>> recordsep in the unaligned mode doesn't play the role of a line ending >>> because the last line is not finished by recordsep. According to the >>> source >>> code, this is intended, see print_unaligned_text() in print.c: >> >> Something else comes to mind: CSV allows linefeeds inside fields, and >> we don't want to replace these with record separators. > > Sure. > >> So the notion that recordsep can be used to choose line endings >> is even less okay than if there was just the last line issue. > > I'm not following. ISTM that the escaping macanism would work in pretty > all reasonable cases, although it might be possible to shot oneself in > the foot by setting manually strange values for recordsep, eg '"'. I do > not see that as a significant issue. If the user asks for something > stupid, they get something stupid, fine. This patch looks like it is getting close but there has been no update in a while. Do you know when you'll have an updated patch that addresses the minor issues brought up in review and the concern above? Regards, -- -David david@pgmasters.net
Commits
-
Add CSV table output mode in psql.
- aa2ba50c2c13 12.0 landed
-
Reorganize format options of psql in alphabetical order
- add9182e5908 12.0 landed
-
Complete TODO item:
- 862b20b38228 8.0.0 cited