Re: use has_privs_of_role() for pg_hba.conf

On 10/6/22 04:09, Michael Paquier wrote:
> On Mon, Apr 04, 2022 at 07:25:51AM -0700, Nathan Bossart wrote:
>> On Mon, Apr 04, 2022 at 09:36:13AM -0400, Joshua Brindle wrote:
>>> Good catch, I think this is a logical followup to the previous
>>> has_privs_of_role patch.
>>> 
>>> Reviewed and +1
>> 
>> Thanks!  I created a commitfest entry for this:
> 
> This patch looks simple, but it is a very sensitive area so I think
> that we should be really careful.  pg_hba.conf does not have a lot of
> test coverage, so I'd really prefer if we add something to see the
> difference of behavior and check the behavior that we are switching
> here.

Agreed

> Joe, you are registered as a reviewer and committer of this patch, by
> the way.  Are you planning to look at it?

I am meaning to get to it, but as you say wanted to spend some time to 
understand the nuances and life keeps getting in the way. I will try to 
prioritize it over the next week.

Joe
-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com