Horton

Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

Florents Tselai <florents.tselai@gmail.com>

View thread
From: Florents Tselai <florents.tselai@gmail.com>
To: "David E. Wheeler" <david@justatheory.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>, Robert Haas <robertmhaas@gmail.com>, Alexander Korotkov <aekorotkov@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2025-07-10T17:41:11Z
Lists: pgsql-hackers 

> On 14 Jun 2025, at 6:08 PM, David E. Wheeler <david@justatheory.com> wrote:
> 
> On Jun 4, 2025, at 11:27, David E. Wheeler <david@justatheory.com> wrote:
> 
>> And these should fix the CI failure. I also ran pgindent.
> 
> Here’s a quick rebase. I think it’s ready for committer review, but since I’ve poked at it quite a bit myself, I updated the Commitfest item [1] to “Needs Review”.
> 
> Best,
> 
> David
> 
> [1]: https://commitfest.postgresql.org/patch/5270/
> 
> <v9-0001-Rename-jsonpath-method-arg-tokens.patch><v9-0002-Add-additional-jsonpath-string-methods.patch>
> 

The basic problem I see with these latest revisions/refactorings is that they fail for pg_upgrade afaict.
Probably this means that some of the rearrangements on the parser/scanner are not that flexible.