Horton

Re: [HACKERS] Regression tests vs existing users in an installation

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2019-11-26T21:10:15Z
Lists: pgsql-hackers 
On 2019-06-29 19:21, Tom Lane wrote:
> Stephen Frost<sfrost@snowman.net>  writes:
>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>> We could make the new subdirectory be something specific like
>>> "src/test/modules/test_rolenames", but I think very likely we'll be
>>> wanting some additional test scripts that we likewise deem unsafe to
>>> run during "installcheck".  So I'd rather choose a more generic module
>>> name, but I'm not sure what ... "unsafe_tests"?
>> Agreed but haven't got any particularly good suggestions on names..
> Hearing no better suggestions, I went with "unsafe_tests" in the
> attached.

I found this directory, and it seems like a good place to add some more 
tests (other thread), but I'm puzzled why it's hidden under modules/, 
since it's not, well, a module.  Why is it not in src/test/?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Move rolenames test out of the core regression tests.

  2. Add an enforcement mechanism for global object names in regression tests.

  3. Fix regression tests to use only global names beginning with "regress_".

  4. Disallow user-created replication origins named "pg_xxx".