Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: David Christensen <david@endpoint.com>, pgsql-hackers@postgresql.org
Date: 2017-02-18T00:16:08Z
Lists: pgsql-hackers
On 2/15/17 10:40, David Christensen wrote: > Throws a build error if we encounter a different number of fields in a > DATA() line than we expect for the catalog in question. > > Previously, it was possible to silently ignore any mismatches at build > time which could result in symbol undefined errors at link time. Now > we stop and identify the infringing line as soon as we encounter it, > which greatly speeds up the debugging process. I think this would be useful. I haven't reviewed the code, but the general idea looks reasonable. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix portability problem in Catalog.pm.
- 15bb93e28e49 10.0 landed
-
Throw an error if a DATA() line contains wrong # of attributes.
- 7666e73a2e9e 10.0 landed