Horton
Menu

Re: Add --{no-,}bypassrls flags to createuser

Shinya Kato <shinya11.kato@oss.nttdata.com>

View thread
From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: Przemysław Sztoch <przemyslaw@sztoch.pl>
Cc: Nathan Bossart <nathandbossart@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael@paquier.xyz>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@postgresql.org
Date: 2022-05-19T01:35:23Z
Lists: pgsql-hackers

Attachments

Thanks for reviews and comments!

On 2022-05-06 07:08, Przemysław Sztoch wrote:

> Thanks for the new patch!  Would you mind adding some tests for the new
> options?

I created a new patch to test the new options!
However, not all option tests exist, so it may be necessary to consider 
whether to actually add this test.


> Too bad there's no --comment parameter to do COMMENT ON ROLE name IS
> 'Comment';
> 
> As you already make such changes in createuser, I would like to ask
> for an additional --comment parameter
> that will allow sysadmins to set a comment with additional information
> about the new DB user.
> psql is scary for some. :-)

Since the createuser command is a wrapper for the CREATE ROLE command, I 
do not think it is appropriate to add options that the CREATE ROLE 
command does not have.


-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix output of createuser --help with --valid-until

  2. createuser: Add support for more clause types through new options

  3. createuser: Cleanup and fix internal option ordering

  4. Add REPLICATION privilege for ROLEs