Re: Support for array_remove and array_replace functions

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marco Nenciarini <marco.nenciarini@2ndquadrant.it>
Cc: Alex Hunsaker <badalex@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-07-11T15:54:50Z
Lists: pgsql-hackers
Marco Nenciarini <marco.nenciarini@2ndquadrant.it> writes:
> Patch v3 attached.

I'm looking at this patch now.  The restriction of array_remove to
one-dimensional arrays seems a bit annoying.  I see the difficulty:
if the input is multi-dimensional then removing some elements could
lead to a non-rectangular array, which isn't supported.  However,
that could be dealt with by decreeing that the *result* is
one-dimensional and of the necessary length, regardless of the
dimensionality of the input.

I'm not actually certain whether that's a better definition or not.
But one less error case seems like generally a good thing.
Comments?

			regards, tom lane