Re: Fix help option of contrib/oid2name

Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>

From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Laurenz Albe <laurenz.albe@cybertec.at>, pgsql-hackers@postgresql.org
Date: 2018-08-20T03:30:29Z
Lists: pgsql-hackers

Attachments

> On August 18, 2018 10:52:33 AM GMT+09:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think it probably needs to stay documented, but we could mark it as
>> deprecated ...
> 
> Okay, no issues with doing so.

I revised the patch like following:

vacuumlo:
    Document
      - Add long options
      - Add environment section

oid2name:
    Document
      - Add long options
      - Add environment section
      - Remove deprecated and unhandled option "-P password"
    Code
      - Revive handling "-H host" option silently

I didn't add "-H" to the help message because it's a deprecated option.
I guess that that means "silently" as you said on previous email.
Should I add it?  For example,

    Not added "-H". (current patch)
    --------
    Connection options:
      -d, --dbname=DBNAME        database to connect to
      -h, --host=HOSTNAME        database server host or socket directory
      -p, --port=PORT            database server port number
      -U, --username=USERNAME    connect as specified database user
    --------

    Added "-H" to the help message after "-h"
    --------
    Connection options:
      -d, --dbname=DBNAME        database to connect to
      -h, -H, --host=HOSTNAME    database server host or socket directory
      -p, --port=PORT            database server port number
      -U, --username=USERNAME    connect as specified database user
    --------

Please find the attached patch.

Regards,
Tatsuro Yamada



Commits

  1. Rework option set of vacuumlo

  2. Rework option set of oid2name