Thread

  1. Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

    SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> — 2026-04-22T22:20:36Z

    Hi Hackers,
    
    A concurrent tablespace drop could lead to null deref in
    pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to
    fix this to keep the code clean.
    
    Thanks,
    Satya
    
  2. Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

    Chao Li <li.evan.chao@gmail.com> — 2026-04-23T00:03:08Z

    
    > On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> wrote:
    > 
    > Hi Hackers,
    > 
    > A concurrent tablespace drop could lead to null deref in pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to fix this to keep the code clean.
    > 
    > Thanks,
    > Satya
    > <0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch>
    
    This is a dup of my recent patch, see [1].
    
    [1] https://www.postgresql.org/message-id/573E45C1-31A4-4885-A00C-1A2171159A2A%40gmail.com
    
    Best regards,
    --
    Chao Li (Evan)
    HighGo Software Co., Ltd.
    https://www.highgo.com/
    
    
    
    
    
    
    
    
  3. Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

    SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> — 2026-04-23T06:48:28Z

    Hi Chao,
    
    On Wed, Apr 22, 2026 at 5:03 PM Chao Li <li.evan.chao@gmail.com> wrote:
    
    >
    >
    > > On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM <
    > satyanarlapuram@gmail.com> wrote:
    > >
    > > Hi Hackers,
    > >
    > > A concurrent tablespace drop could lead to null deref in
    > pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to
    > fix this to keep the code clean.
    > >
    > > Thanks,
    > > Satya
    > >
    > <0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch>
    >
    > This is a dup of my recent patch, see [1].
    >
    > [1]
    > https://www.postgresql.org/message-id/573E45C1-31A4-4885-A00C-1A2171159A2A%40gmail.com
    
    
    Thanks, I replied there.