Re: relation OID in ReorderBufferToastReplace error message
Jeremy Schneider <schnjere@amazon.com>
From: "Schneider (AWS), Jeremy" <schnjere@amazon.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-07-02T02:12:01Z
Lists: pgsql-hackers
> On Jul 1, 2021, at 18:57, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > But I wonder why > print the parent's OID, when we have access to its name. Seems like a few people do schema-based multi-tenancy with similarly named relations in different namespaces, so I’d have a preference for OID over an unqualified relation name. Also the error message shows the OID for the toast relation so this is consistent. Relation name could work too though, especially if the schema was included -Jeremy Sent from my TI-83
Commits
-
Back-patch "Add parent table name in an error in reorderbuffer.c."
- 4d3147070545 9.6.24 landed
- 13e52d7c5533 10.19 landed
- d61cdad0b524 11.14 landed
- 4048fc458175 12.9 landed
- 23469b867ac0 13.5 landed
- 9e84f6a72133 14.1 landed
-
Add parent table name in an error in reorderbuffer.c.
- 5e77625b260a 15.0 landed
-
Fix reorder buffer memory accounting for toast changes.
- df3640e5293d 15.0 cited
-
Add logical change details to logical replication worker errcontext.
- abc0910e2e0a 15.0 cited
-
Fix toast rewrites in logical decoding.
- 29b590547028 15.0 cited
-
Add error codes to some corruption log messages
- fd6ec93bf890 13.0 cited