Horton

Re: pg_stat_io not tracking smgrwriteback() is confusing

Jonathan S. Katz <jkatz@postgresql.org>

View thread View on postgr.es
From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Andres Freund <andres@anarazel.de>
Cc: Melanie Plageman <melanieplageman@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org
Date: 2023-05-04T19:41:57Z
Lists: pgsql-hackers 
On 5/4/23 12:46 PM, Andres Freund wrote:
> Hi,
> 
> On 2023-05-03 11:36:10 -0400, Jonathan S. Katz wrote:
>> It'd be good if we can get this into Beta 1 if everyone is comfortable with
>> the patch.
> 
> I think we need one more iteration, then I think it can be committed. The
> changes are docs phrasing and polishing the API a bit, which shouldn't be too
> hard.  I'll try to look more tomorrow.

[RMT hat, personal opinion]

Great to hear. From my skim of the patch, I had thought the conclusion 
would be something similar, but did want to hear from you & Melanie on that.

Thanks,

Jonathan

Commits

  1. Add writeback to pg_stat_io

  2. Update parameter name context to wb_context

  3. Use BUFFER_USAGE_LIMIT to reduce needed test table size