Re: [PATCH] Add tests for Bitmapset

Greg Burd <greg@burd.me>

View thread

From: Greg Burd <greg@burd.me>

To: Michael Paquier <michael@paquier.xyz>, David Rowley <dgrowleyml@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-30T09:30:51Z

Lists: pgsql-hackers

Attachments

v1-0001-Don-t-check-for-NULL-before-calling-bms_free-in-t.patch (application/octet-stream) patch v1-0001

On Sep 29 2025, at 8:51 pm, Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote:
>> NULL is a valid Bitmapset, so I don't really see the need to check for
>> an empty set before calling bms_free().  If those were removed, then
>> you'd not have to care about the coverage of that line.

Good point, I agree.  Thanks for reporting/reviewing David.

> Yeah, we could just remove them as you are suggesting, as well.
> --
> Michael

Thank you both, patch attached.

best.

-greg

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Minor fixes for test_bitmapset.c
- 5142f0093e64 19 (unreleased) landed
test_bitmapset: Improve random function
- 9d46b86529e8 19 (unreleased) landed
Add mem_exceeded_count column to pg_stat_replication_slots.
- d3b6183dd988 19 (unreleased) landed
Tidy-up unneeded NULL parameter checks from SQL function
- a69b55cd4727 19 (unreleased) landed
Remove check for NULL in STRICT function
- 381f5cffae00 19 (unreleased) landed
Fixes for comments in test_bitmapset
- a1b064e4b226 19 (unreleased) landed
Minor fixups of test_bitmapset.c
- 3a6615806859 19 (unreleased) landed
test_bitmapset: Simplify code of the module
- 9952f6c05a40 19 (unreleased) landed
test_bitmapset: Expand more the test coverage
- 5668fff3c512 19 (unreleased) landed
Fix compiler warnings in test_bitmapset
- f83fe65f3fc1 19 (unreleased) landed
Add a test module for Bitmapset
- 00c3d87a5cab 19 (unreleased) landed