Horton

[PATCH][HOTFIX] vacuum_cost_delay type change from int to real have not been done everywhere

Nikolay Shaplov <dhyan@nataraj.su>

View thread View on postgr.es
From: Nikolay Shaplov <dhyan@nataraj.su>
To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Julien Rouhaud <rjuju123@gmail.com>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, David Rowley <david.rowley@2ndquadrant.com>, Jeff Janes <jeff.janes@gmail.com>, Jeremy Schneider <schnjere@amazon.com>, Joe Conway <mail@joeconway.com>, Peter Geoghegan <pg@bowt.ie>
Date: 2019-03-26T16:19:50Z
Lists: pgsql-hackers

Attachments

Hi!

In caf626b2 type of vacuum_cost_delay have been switched from int to real, 
everywhere, but not in *RelOpts[] arrays.

For some reason it continued to build and work. But I think it is better to 
move vacuum_cost_delay from int to real there too...

Patch attached.

PS. As you can see current reloption code is error-prone. To properly change 
reloptions you should simultaneously change code in several different places, 
and as you can see, it may not report if you missed something.
I am working on reloptions code refactoring now, please join reviewing my 
patches. This work is important as you can see from this example...

Commits

  1. Fix oversight in data-type change for autovacuum_vacuum_cost_delay.