Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-02-05T14:29:08Z
Lists: pgsql-hackers

Attachments

On 2023-02-04 Sa 09:20, Andrew Dunstan wrote:
>
>
> On 2023-02-04 Sa 06:34, Andres Freund wrote:
>>
>> ISTM that we're closer to being able to enforce pgindent than
>> perltidy. At the same time, I think the issue of C code in HEAD not
>> being indented is more pressing - IME it's much more common to have to
>> touch a lot of C code than to have to touch a lot fo perl files.  So
>> perhaps we should just start with being more stringent with C code, and
>> once we made perltidy less noisy, add that?
>>
>
> Sure, we don't have to tie them together.
>
> I'm currently experimenting with settings on the buildfarm code, 
> trying to get it both stable and looking nice. Then I'll try on the 
> Postgres core code and post some results.
>

So here's a diff made from running perltidy v20221112 with the 
additional setting --valign-exclusion-list=", = => || && if unless"

Essentially this abandons those bits of vertical alignment that tend to 
catch us out when additions are made to the code.

I think this will make the code much more maintainable and result in 
much less perltidy churn. It would also mean that it's far more likely 
that what we would naturally code can be undisturbed by perltidy.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.