Re: LLVM strip -x fails

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

To: Andres Freund <andres@anarazel.de>, Palle Girgensohn <girgen@pingpong.net>, pgsql-hackers@postgresql.org

Date: 2023-04-21T16:49:04Z

Lists: pgsql-hackers

On 21.04.23 18:41, Peter Eisentraut wrote:
> On 20.04.23 17:33, Andres Freund wrote:
>> Peter, it's unlikely given the timeframe, but do you happen to 
>> remember why
>> you specified -x when stripping static libs? This seems to be all the 
>> way back
>> from
>>
>> commit 563673e15db995b6f531b44be7bb162330ac157a
>> Author: Peter Eisentraut<peter_e@gmx.net>
>> Date:   2002-04-10 16:45:25 +0000
>>
>>      Add make install-strip target.
>>
>>
>> Afaict the only safe thing to use when stripping static libs is
>> -g/--strip-debug.
> 
> I suspect this was copied from GNU Libtool.  Libtool still has that but 
> later changed the stripping of static libraries on darwin to "strip -S". 
>   Maybe should adopt that.

Here is the current logic in GNU Libtool:

https://github.com/autotools-mirror/libtool/blob/master/m4/libtool.m4#L2214

Commits

Use --strip-unneeded when stripping static libraries with GNU strip.
- a14afd3bdc21 15.3 landed
- eab2d3147e3c 16.0 landed
- e2e34dfff5e7 12.15 landed
- c976ccc9e557 11.20 landed
- 6dce37203410 13.11 landed
- 6d60b718ceb0 14.8 landed
Add make install-strip target.
- 563673e15db9 7.3.1 cited