Horton

Thread

Commits

  1. Fix access-off-end-of-array in clog.c.

  1. postgresql-10.0/src/backend/access/transam/clog.c:234: sanity check after use ?

    David Binderman <dcb314@hotmail.com> — 2017-10-06T15:15:46Z

    Hello there,


postgresql-10.0/src/backend/access/transam/clog.c:234]: (style) Array index 'i' is used before limits check.

Source code is

        while (TransactionIdToPage(subxids[i]) == pageno && i < nsubxids)

Maybe it is better to sanity check the array index before use, not after.

Regards

David Binderman

  2. Re: postgresql-10.0/src/backend/access/transam/clog.c:234: sanity check after use ?

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-10-06T15:52:59Z

    David Binderman <dcb314@hotmail.com> writes:
> postgresql-10.0/src/backend/access/transam/clog.c:234]: (style) Array index 'i' is used before limits check.

Yeah, this is pretty bogus, will fix (and the same for your other one).

			regards, tom lane