Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Drouvot, Bertrand <bdrouvot@amazon.com>

From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
To: Hamid Akhtar <hamid.akhtar@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-01T08:01:33Z
Lists: pgsql-hackers
Hi,

On 6/30/22 10:24 AM, Hamid Akhtar wrote:
> On Mon, 27 Jun 2022 at 15:52, Bharath Rupireddy 
> <bharath.rupireddyforpostgres@gmail.com> wrote:
>
>     On Mon, Jun 27, 2022 at 1:40 PM Drouvot, Bertrand
>     <bdrouvot@amazon.com> wrote:
>     >
>     > Hi,
>     >
>     > On 6/27/22 9:31 AM, Hamid Akhtar wrote:
>     >
>     >
>     > Hello Hackers,
>     >
>     > While working on one of my blogs on the B-Tree indexes, I needed
>     to look at a range of B-Tree page statistics. So the goto solution
>     was to use pageinspect. However, reviewing stats for multiple
>     pages meant issuing multiple queries.
>
>     +1 to improve the API.
>
I think it makes sense too.

But what about the other pageinspect's functions that also use a single 
blkno as parameter? Should not the patch also takes care of them?

Regards,

Bertrand

Commits

  1. Add bt_multi_page_stats() function to contrib/pageinspect.