Re: [BUG] pg_dump blocked

Gilles DAROLD <gilles@darold.net>

View thread View on postgr.es

From: Gilles Darold <gilles@darold.net>

To: Tom Lane <tgl@sss.pgh.pa.us>, Gilles Darold <gilles@darold.net>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2022-11-19T06:30:59Z

Lists: pgsql-hackers

Attachments

0001-move-unsafe-function-calls-14-backport-1.patch (text/x-patch) patch 0001
0002-move-unsafe-function-calls-13-backport-1.patch (text/x-patch) patch 0002
0003-move-unsafe-function-calls-12-backport-1.patch (text/x-patch) patch 0003
0004-move-unsafe-function-calls-11-backport-1.patch (text/x-patch) patch 0004

Le 17/11/2022 à 17:59, Tom Lane a écrit :
> Gilles Darold <gilles@darold.net> writes:
>> I have an incorrect behavior with pg_dump prior PG version 15. With
>> PostgreSQL 15, thanks to commit e3fcbbd623b9ccc16cdbda374654d91a4727d173
>> the problem is gone but for older versions it persists with locks on
>> partitioned tables.
> I didn't want to back-patch e3fcbbd62 at the time, but it's probably aged
> long enough now to be safe to back-patch.  If we do anything here,
> it should be to back-patch the whole thing, else we've only partially
> fixed the issue.

Here are the different patched following the PostgreSQL version from 11 
to 14, they should apply on the corresponding stable branches. The 
patches only concern the move of the unsafe functions, 
pg_get_partkeydef() and pg_get_expr(). They should all apply without 
problem on their respective branch, pg_dump tap regression test passed 
on all versions.

Regards,

-- 
Gilles Darold

Commits

pg_dump: avoid unsafe function calls in getPolicies().
- b7333e826955 11.19 landed
- a5b26aaafe4f 13.10 landed
- 1ed6f1b9116c 12.14 landed
- 03ac48549438 14.7 landed
Postpone calls of unsafe server-side functions in pg_dump.
- e46e986baef0 13.10 landed
- b1f106420b1a 11.19 landed
- 55f30e6c7640 14.7 landed
- 344b7849200f 12.14 landed
- e3fcbbd623b9 15.0 cited