Horton

Remove useless casts to (void *)

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-29T08:06:32Z
Lists: pgsql-hackers

Attachments

There are a bunch of (void *) casts in the code that don't make sense to 
me.  I think some of these were once necessary because char * was used 
in place of void * for some function arguments.  And some of these were 
probably just copied around without further thought.  I went through and 
cleaned up most of these.  I didn't find any redeeming value in these. 
They are just liable to hide actual problems such as incompatible types. 
  But maybe there are other opinions.

Commits

  1. Remove PointerIsValid()

  2. Define __EXTENSIONS__ on Solaris, too.

  3. Define _POSIX_C_SOURCE as 200112L on Solaris.

  4. Remove useless casts to (void *)