Re: SerializeParamList vs machines with strict alignment
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2018-10-02T00:01:54Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes: > On Tue, Oct 2, 2018 at 9:49 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Apparently the only somewhat-modern architecture that is resolutely >> unaligned-unfriendly is MIPS. > It's been a few years now since I worked on that architecture, but > Sparc is somewhat-modern and resolutely unaligned-unfriendly. It's > just that you can optionally install a trap handler that will do super > slow non-atomic misaligned access in software instead of blowing up > with SIGBUS. With the Sun toolchain you did that explicitly by > building with -misalign (though it's possible that more recent > compilers might be doing that without being asked?). Interesting ... I suppose we'd have seen that on the Sparc critters, except that they weren't running with force_parallel_mode = regress like chipmunk is. Now I'm tempted to propose that Amit commit *just* the test case and not the fix, and wait a day to see which buildfarm critters fail. regards, tom lane
Commits
-
MAXALIGN the target address where we store flattened value.
- dca44d07c585 9.6.11 landed
- 9718c93f532c 10.6 landed
- 9bc9f72b28fe 12.0 landed
- ca5ca25d0871 11.0 landed
-
Test passing expanded-value representations to workers.
- 0fd6a8a7d0ce 12.0 landed