Re: tests fail on windows with default git settings

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Dave Page <dpage@pgadmin.org>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2024-07-10T14:03:50Z
Lists: pgsql-hackers
On 2024-07-10 We 9:25 AM, Tom Lane wrote:
> Dave Page <dpage@pgadmin.org> writes:
>> On Wed, 10 Jul 2024 at 12:12, Andrew Dunstan <andrew@dunslane.net> wrote:
>>> As I was looking at this I wondered if there might be anywhere else that
>>> needed adjustment. One thing that occurred to me was that that maybe we
>>> should replace the use of "-w" in pg_regress.c with this rather less
>>> dangerous flag, so instead of ignoring any white space difference we would
>>> only ignore line end differences. The use of "-w" apparently dates back to
>>> 2009.
>> That seems like a good improvement to me.
> +1
>
> 			


OK, done.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




Commits

  1. Use diff --strip-trailing-cr in pg_regress.c

  2. Use diff's --strip-trailing-cr flag where appropriate on Windows