Horton

Re: fairywren hung in pg_basebackup tests

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-07-27T14:32:29Z
Lists: pgsql-hackers 
On 2022-07-27 We 10:24, Alvaro Herrera wrote:
> On 2022-Jul-27, Andrew Dunstan wrote:
>
>> The msys dirent.h doesn't have a d_type field at all in a struct dirent.
>> I can see a number of ways of dealing with this, but the simplest seems
>> to be just to revert 5344723755, at least for msys, along with a comment
>> about why it's necessary.
> Hmm, what other ways there are?  I'm about to push a change that
> duplicates the get_dirent_type call pattern and I was happy about not
> having that #ifdef there.  Not that it's critical, but ...



The alternative I thought of would be to switch msys to using our
dirent.c. Probably not too hard, but certainly more work than reverting.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Fix get_dirent_type() for symlinks on MinGW/MSYS.