Horton

Thread

Commits

  1. Fix typo: colums -> columns.

  1. A typo in error message

    Alexander Law <exclusion@gmail.com> — 2018-01-31T05:47:57Z

    Hello,

Please consider committing the attached patch to fix a typo in error 
message.

Best regards,

-- 
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

  2. Re: A typo in error message

    Michael Paquier <michael.paquier@gmail.com> — 2018-01-31T05:53:04Z

    On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:
> Please consider committing the attached patch to fix a typo in error
> message.

Yeah..

>  		if (cxt->ofType)
>  			ereport(ERROR,
>                               	(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> -                             	 errmsg("identity colums are not supported on typed tables")));
> +                             	 errmsg("identity columns are not supported on typed tables")));
>  		if (cxt->partbound)
>  			ereport(ERROR,
>  				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

The indentation for this ereport() is weird as well here.
--
Michael

  3. Re: A typo in error message

    Robert Haas <robertmhaas@gmail.com> — 2018-01-31T21:47:03Z

    On Wed, Jan 31, 2018 at 12:53 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:
>> Please consider committing the attached patch to fix a typo in error
>> message.
>
> Yeah..

Committed.

>>               if (cxt->ofType)
>>                       ereport(ERROR,
>>                                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>> -                                      errmsg("identity colums are not supported on typed tables")));
>> +                                      errmsg("identity columns are not supported on typed tables")));
>>               if (cxt->partbound)
>>                       ereport(ERROR,
>>                               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>
> The indentation for this ereport() is weird as well here.

Hit it with pgindent to fix this, too.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company