Horton

Re: [PATCH] Clean up property graph error messages

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2026-05-07T08:45:13Z
Lists: pgsql-hackers 
On 04.05.26 21:57, Ayush Tiwari wrote:
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
> 
> The attached patch fixes a user-visible error message from "mismatching
> properties names" to "mismatching property names",

I have fixed that.

> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties().
> 
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.

I think that's fine.  I don't think the change makes this better.