Re: SPITupleTable members missing in docs
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Daniel Gustafsson <daniel@yesql.se>, pgsql-docs@lists.postgresql.org,
Michael Paquier <michael@paquier.xyz>
Date: 2019-07-12T15:04:39Z
Lists: pgsql-docs
Fabien COELHO <coelho@cri.ensmp.fr> writes:
> To take into account Tom's comment, I'd suggest a middle ground by
> commenting a public and private part explicitely in the struct, something
> like:
> typedef struct {
> /* PUBLIC members to be used by callers ... */
> ...
> ...
> /* PRIVATE members, not intended for external usage ... */
> ...
> } ... ;
One problem is that the members we've retroactively decided are "public"
are in the middle of the struct :-(.
But it occurs to me that there's no good reason we couldn't re-order the
members, as long as we only do so on HEAD and not in released versions.
That would make it a bit less inconsistent and easier to add labels
such as you suggest.
> Note: I'm probaly not a member of the pgdoc list, so the delivery may fail
> there.
FYI, I believe the current policy is that as long as you're subscribed
to at least one PG list you can post to any of them.
regards, tom lane
Commits
-
Clarify the distinction between public and private SPITupleTable fields.
- fec0778c8098 13.0 landed
-
Prevent leakage of SPI tuple tables during subtransaction abort.
- 3d13623d75d3 9.4.0 cited