Re: Remove MSVC scripts from the tree

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: vignesh C <vignesh21@gmail.com>, Michael Paquier <michael@paquier.xyz>

Cc: Shubham Khanna <khannashubham1197@gmail.com>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2023-12-19T15:24:02Z

Lists: pgsql-hackers

Attachments

0001-meson-Require-sed-only-when-needed.patch (text/plain) patch 0001
0002-meson-Make-gzip-and-tar-optional.patch (text/plain) patch 0002

On 18.12.23 14:52, Peter Eisentraut wrote:
>> 2) I had seen that if sed/gzip is not available meson build will fail:
>> 2.a)
>> Program gsed sed found: NO
>> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
> 
> Yes, this would need to be improved.  Currently, sed is only required if 
> either selinux or dtrace is enabled, which isn't supported on Windows. 
> But we should adjust the build scripts to not fail the top-level setup 
> run unless those options are enabled.
> 
>> 2.b)
>> Program gzip found: NO
>> meson.build:337:7: ERROR: Program 'gzip' not found or not executable
> 
> gzip is only required for certain test suites, so again we should adjust 
> the build scripts to not fail the build but instead skip the tests as 
> appropriate.

Here are patches for these two issues.  More testing would be appreciated.

Commits

Make win32tzlist.pl checkable again
- 8ddf9c1dc020 17.0 landed
meson: Make gzip and tar optional
- 9ca6e7b9411e 17.0 landed
meson: Make sed optional
- 9aa374dcfb76 17.0 landed
Remove MSVC scripts
- 1301c80b2167 17.0 landed
Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
- 3849fe7c2ba7 17.0 landed