Horton

Re: tests against running server occasionally fail, postgres_fdw & tenk1

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Michael Paquier <michael.paquier@gmail.com>, Fujii Masao <fujii@postgresql.org>
Date: 2023-02-26T21:03:13Z
Lists: pgsql-hackers 
I wrote:
> I'm inclined to think we should indeed just nuke that test.  It's
> overcomplicated and it expends a lot of test cycles on a pretty
> marginal feature.

Perhaps a better idea: at the start of the test, set
postgres_fdw.application_name to something that exercises all the
available escape sequences, but don't try to verify what the
result looks like.  That at least gives us code coverage for the
escape sequence processing code, even if it doesn't prove that
the output is desirable.

			regards, tom lane

Commits

  1. Harden postgres_fdw tests against unexpected cache flushes.

  2. meson: Add 'running' test setup, as a replacement for installcheck

  3. Revert "Temporarily add some probes of tenk1's relallvisible in create_index.sql."

  4. Disable cache clobber to avoid breaking postgres_fdw termination test.

  5. Simplify the example of VACUUM in documentation.