Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hugh McMaster <hugh.mcmaster@outlook.com>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-03-16T21:04:05Z
Lists: pgsql-hackers
> On 16 Mar 2020, at 17:12, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Still, I think the number of people who'd get bit by that could be > counted without running out of fingers, while it seems quite likely > that many people will soon need to build our back branches on > platforms that won't have xml2-config. I agree with this assessment. > So I'm now leaning to "back-patch and make sure to mention this in > the next release notes". Barring objections, I'll do that soon. None from me. > I don't have a problem with s/libxml/libxml2/ in the running text > (without changing the switch name). +1 > Can't get too excited about > <productname> though. I think we've only consistently applied > that tag to PostgreSQL itself. Fair enough. Looking at a random sample it seems we use a bit of a mix of nothing, <application /> and <productname /> (the latter ones being more or less equal in DocBook IIRC) to mark up externals. cheers ./daniel
Commits
-
Use pkg-config, if available, to locate libxml2 during configure.
- d67d7243f914 10.13 landed
- 9af2f7dc9603 11.8 landed
- d8e7f8149400 12.3 landed
- 0bc8cebdb889 13.0 landed