Re: Fix gistkillitems & add regression test to microvacuum
x4mmm@yandex-team.ru
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-01-20T10:30:30Z
Lists: pgsql-hackers
> On 15 Jan 2026, at 22:59, Kirill Reshke <reshkekirill@gmail.com> wrote: > > PFA v2 which leaves the test in-place. > > Also commit message improvements. Yeah, killtuples for GiST root page is broken. Your patch is fixing it. I don't think we should backpatch this, the bug is harmless, but for master the patch LGTM. It would be good to assign so->curBlkno and so->curBlkno together. But gistScanPage() is the only place with access to the block number. +# Test gist, but with fewer rows - that killitems used to be buggy. Probably, in this comment we can explicitly say that killitems was buggy, but now is fixed. Thanks! Best regards, Andrey Borodin.
Commits
-
Fix use of wrong variable in _hash_kill_items()
- f5eb854ab6d6 19 (unreleased) cited