Re: pg_basebackup and error messages dependent on the order of the arguments
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-10-03T19:32:31Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Wed, Oct 2, 2024 at 6:00 AM Daniel Westermann (DWE) > <daniel.westermann@dbi-services.com> wrote: >> Maybe checking if a valid "-D" or "--pgdata" was given and return a more generic error message would be an option? > It doesn't really seem reasonable to me to make the tools guess > whether somebody left out the argument to an option that requires an > argument. Consider these equivalent cases: > ... > I assume there are similar cases that don't involve PostgreSQL at all. Yeah. This has to be a standard problem for anything that uses getopt or getopt_long at all. Unless there's a standard approach (which I've not heard of) to resolving these ambiguities, I'm not sure that we should try to outsmart everybody else. In the case of getopt_long there's an additional problem, which is that that function itself may contain heuristics that rearrange the argument order based on what looks like a switch or not. It's likely that anything we did on top of that would behave differently depending on which version of getopt_long it is. regards, tom lane