Horton

Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-01-23T20:12:22Z
Lists: pgsql-hackers 
On 2025-01-23 Th 3:18 AM, Srinath Reddy wrote:
> Hi,
>
> in pg_restore archive format option is parsed using only the first 
> character of the value but in pg_dump the archive format option's 
> value is compared with whole string using pg_strcasecmp is there any 
> specific reason?
>
>


`git blame` tells me that this switch statement goes back to 2001. 
Seeking a reason at this distance is unlikely to be productive. Probably 
we were not nearly as careful then as we are now about such things. Feel 
free to submit a patch tightening the test.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Tighten pg_restore's recognition of its -F (format) option values.