Horton

Re: unused_oids script is broken with bsd sed

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-25T14:18:37Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> +many for rewriting in perl. Do you want to have a go at that? If not I
> will.

+1 ... I was mildly astonished that this didn't already have to happen
as part of the bootstrap data conversion effort.  It's certainly not
hard to imagine future extensions to the .dat file format that would
break this script, and duplicate_oids too.  I think we should rewrite
both of them to use the Catalog.pm infrastructure.

			regards, tom lane

Commits

  1. Blindly try to fix MSVC build's use of genbki.pl and Gen_fmgrtab.pl.

  2. Avoid overwriting unchanged output files in genbki.pl and Gen_fmgrtab.pl.

  3. Rearrange makefile rules for running Gen_fmgrtab.pl.

  4. Avoid parsing catalog data twice during BKI file construction.

  5. Fix duplicate_oids and unused_oids so user needn't cd to catalog dir.

  6. Convert unused_oids and duplicate_oids to use Catalog.pm infrastructure.

  7. Make Catalog.pm's representation of toast and index decls more abstract.