Re: More tests to stress directly checksum_impl.h
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Steele <david@pgmasters.net>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-03-08T19:12:11Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes: > Thanks for the computations with big-endian! I would have just gone > down to the 8kB page for the expected results by seeing three other > tests blowing up, but no objection to what you have here either. I > have checked the computations with little-endian from your patch and > these are correct. After thinking more I concluded that the extra expected files would just be a waste of tarball space, at least till such time as we make a push to fix all the regression tests to be blocksize-independent. Pushed it with just the 8K files. regards, tom lane
Commits
-
Add an explicit test to catch changes in checksumming calculations.
- 38ce06c37e9c 13.0 landed