Horton

Re: Lack of Sanity Checking in file 'pctcl.c' for PostgreSQL 9.4.x

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, Bill Parker <wp02855@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Date: 2015-06-13T03:41:51Z
Lists: pgsql-bugs 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Michael Paquier wrote:
>> By the way, your patch does not compile properly and is not in-line
>> with the project's code format. See the updated patch attached ;)

> ... or the conventions for allocating memory.  Why not just use palloc()?

That's hardly the fault of the proposed patch.  But yeah, it seems like
much the best fix here is to get rid of the malloc (and strdup) calls in
this code in favor of using the palloc infrastructure.  Even the calls
that *do* have manual failure checks are not compliant with our usual
coding standards.

			regards, tom lane

Commits

  1. Fix (some of) pltcl memory usage