Horton

Re: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Itamar Gafni <itamar.gafni@imperva.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-12T13:32:27Z
Lists: pgsql-hackers 
> On 12 Aug 2021, at 12:00, Itamar Gafni <itamar.gafni@imperva.com> wrote:

> Copying it means there are two BIO_METHOD objects with the same type (ortig
> socket and its copy) but it's unclear if that's an issue.


Reading code there doesn't seem to be a concensus really, Apple is doing it in
the Swift TLS code but otheres aren't.  Considering there's been no complaints
on this and OpenSSL < 1.1.0 is EOL I say we leave it for now.

Barring objections I will go ahead with your proposed patch on HEAD and
backpatch it all the way, once I've done more testing on it.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Set type identifier on BIO