Re: Dubious usage of TYPCATEGORY_STRING

On 07.12.21 21:24, Tom Lane wrote:
> I wrote:
>> Peter Eisentraut<peter.eisentraut@enterprisedb.com>  writes:
>>> Could we add explicit casts (like polcmd::text) here?  Or would it break
>>> too much?
>> I assumed it'd break too much to consider doing that.  But I suppose
>> that since a typcategory change would be initdb-forcing anyway, maybe
>> it's not out of the question.  I'll investigate and see exactly how
>> many places would need an explicit cast.
> Um, I definitely gave up too easily there.  The one usage in \dp
> seems to be the*only*  thing that breaks in describe.c, and pg_dump
> doesn't need any changes so far as check-world reveals.  So let's
> just move "char" to another category, as attached.

Looks good to me.