Horton

Thread

Commits

  1. Clean test_rls_hooks module

  1. clean up test_rls_hooks module

    Andrew Dunstan <andrew@dunslane.net> — 2022-03-23T13:31:04Z

    Over at [1] Mark Dilger got led astray because he used
src/test/modules/test_rls_hooks as a template for his new test module.
It looks like that module was created with some over eager copying of
another test module, but it has a couple of things wrong with it.

. it isn't an extension, so the Makefile shouldn't have an EXTENSION
entry, and there shouldn't be a .control file

. it doesn't need to be preloaded so there is no requirement for a
special config, nor for corresponding REGRESS_OPTS and NO_INSTALLCHECK
lines in the Makefile.

Here's a patch to fix those things.


cheers


andrew


[1]
https://postgr.es/m/47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  2. Re: clean up test_rls_hooks module

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-03-23T14:07:06Z

    Andrew Dunstan <andrew@dunslane.net> writes:
> Here's a patch to fix those things.

Seems reasonable to me, except that I think I'd leave the formatting
of the OBJS macro alone.  IIRC, Andres or someone went around and
made all of those follow this one-file-per-line style some time ago.

			regards, tom lane

  3. Re: clean up test_rls_hooks module

    Andres Freund <andres@anarazel.de> — 2022-03-23T15:45:11Z

    Hi,

On 2022-03-23 10:07:06 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Here's a patch to fix those things.
> 
> Seems reasonable to me, except that I think I'd leave the formatting
> of the OBJS macro alone.  IIRC, Andres or someone went around and
> made all of those follow this one-file-per-line style some time ago.

Yea. merge conflicts are considerably rarer that way, and a heck of a lot
easier to deal with when they occur.

Greetings,

Andres Freund