Horton

Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jchampion@timescale.com>, heath.lord@crunchydata.com, pgsql-bugs@lists.postgresql.org
Date: 2022-09-29T21:29:14Z
Lists: pgsql-bugs 
Daniel Gustafsson <daniel@yesql.se> writes:
> Reading a few lines further down in the docs I noticed this description for the
> compression parameter to PQsslAttribute:

> 	"If SSL compression is in use, returns the name of the compression
> 	algorithm, or "on" if compression is used but the algorithm is not
> 	known.  If compression is not in use, returns "off"."

> AFAICT that has never been the case since 91fa7b4719ac, it has always just
> returned "on" or "off" and never the name of the compression algorithm.  I
> propose to apply the attached backpatched to make the docs align with the code.

Yeah, it clearly doesn't do that.  +1

			regards, tom lane

Commits

  1. Adjust PQsslAttributeNames() to match PQsslAttribute().

  2. doc: Fix PQsslAttribute docs for compression

  3. Fix bogus behavior of PQsslAttribute(conn, "library").

  4. Enable SSL library detection via PQsslAttribute()