Horton

Re: BUG #18483: Segmentation fault in tests modules

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org, Masahiko Sawada <sawada.mshk@gmail.com>, johncnaylorls@gmail.com
Date: 2024-06-08T05:00:00Z
Lists: pgsql-bugs 
Hello Michael and Tom,

08.06.2024 01:29, Michael Paquier wrote:
> On Fri, Jun 07, 2024 at 04:32:56PM -0400, Tom Lane wrote:
>> The test_predtest problem is mine, will fix it in a bit.
> Thanks.

May I ask you about the project policy regarding such test modules
failures?

Do you think all of these should be fixed or it's ok to have some
server-crashing modules in the tree?

I'm asking because I collected a number of such defects but didn't dare to
report them yet.

For example:
echo "CREATE EXTENSION test_shm_mq;
SELECT test_shm_mq_pipelined(64, '', 1, 0);
" > src/test/modules/test_shm_mq/sql/test_shm_mq.sql

make -s check -C src/test/modules/test_shm_mq/
leads to:
1087            Assert(handle->slot < max_worker_processes);
(gdb) bt
#0  GetBackgroundWorkerPid (handle=0x7f7f7f7f00000000, ...) at bgworker.c:1087
#1  0x000055cab243b2a6 in shm_mq_counterparty_gone (...) at shm_mq.c:1193
...

Best regards,
Alexander

Commits

  1. Make regress function make_tuple_indirect() able to handle plain attributes

  2. Fix segmentation fault in test_tidstore.

  3. Tighten test_predtest's input checks, and improve error messages.