Horton

Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: 2022-12-29T00:05:35Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
>> Hmm ... I guess the buildfarm would tell us whether that detection works
>> correctly on platforms where it matters.  Let's keep it simple if we
>> can.

> Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
> that it suffices to use -Werror=unknown-pragmas without a separate configure
> check?

I'd try -Werror=unknown-pragmas, and then go to the #ifdef if that
doesn't seem to work well.

			regards, tom lane

Commits

  1. perl: Hide warnings inside perl.h when using gcc compatible compiler