Re: [HACKERS] pgbench - allow to store select results into variables
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Stephen Frost <sfrost@snowman.net>,
PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2018-08-14T12:35:49Z
Lists: pgsql-hackers
On 08/14/2018 07:37 AM, Andrew Gierth wrote: >>>>>> "Andrew" == Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes: > >>> This patch contains CRLF line endings > >> > >> Alas, not according to "file" nor "hexdump" (only 0A, no 0D) on my > >> local version, AFAICS. > >> > >> What happens on the path and what is done by mail clients depending > >> on the mime type is another question (eg text/x-diff or text/plain). > > Andrew> It's not done by my MUA, and it's present in your latest posted > Andrew> patch. If anything I'd suspect your MUA: > > The patch in the original email is in text/plain with base64 transfer > encoding, which means that CRLF line endings are mandatory. It's > actually up to the receiving MUA (or the archives webserver) to undo > that. > > If the archives webserver isn't handling that then it's a bug there. > Probably a good reason not to use text/plain for patches, ISTM. I do note that my MUA (Thunderbird) uses text/x-patch and probably violates RFC2046 4.1.1 cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
pgbench: Remove \cset
- 25ee70511ec2 12.0 landed
-
pgbench: add \cset and \gset commands
- 6260cc550b0e 12.0 landed
-
Adjust pgbench to allow non-ASCII characters in variable names.
- 9d36a386608d 11.0 landed
-
Refactor script execution state machine in pgbench.
- 12788ae49e19 10.0 cited
-
Allow empty queries in pgbench.
- 6471045230f5 10.0 cited